Style: Make components themeable #5908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 10/06/2025, 09:59:51 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 10/06/2025, 11:26:54 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
DrJKL
requested review from
Myestery,
arjansingh,
christian-byrne,
jtydhr88,
ltdrdata,
pythongosssss,
viva-jinyi and
webfiltered
as code owners
dosubot
bot
added
the
size:L
christian-byrne
added
the
claude-review
DrJKL
added
the
New Browser Test Expectations
DrJKL
added
New Browser Test Expectations
arjansingh
previously approved these changes
Oct 5, 2025
.storybook/README.md
Outdated
| ## Icon Usage in Storybook | ||
|
|
||
| In this project, the `<i-lucide:... />` syntax from unplugin-icons is not supported in Storybook. | ||
| In this project, the `<i class="icon-[lucide--folder]" />` syntax from unplugin-icons is not supported in Storybook. |
There was a problem hiding this comment.
non-blocker: This should go in the root CLAUDE.md as well. Will prevent many bad generations.
DrJKL
added
New Browser Test Expectations
DrJKL
added
New Browser Test Expectations
dosubot
bot
removed
the
size:L
fix: Collapse button sizing Fix: add back a little sizing to the button
test: Update collapse locators
DrJKL
added
New Browser Test Expectations
@webfiltered, I removed the icon stuff from this PR, I'll do it as a standalone. |
christian-byrne
approved these changes
Oct 6, 2025
Awesome! It also made it smaller and easier to peruse and LGTM. 😃 |
arjansingh
pushed a commit
that referenced
this pull request
Oct 7, 2025
Replace color/dark-color pairs in components with design tokens to allow for easy overriding. <!-- Also standardizes the icon pattern to simplify the tailwind config. --> - **What**: Token based colors, for now, mostly. - **Breaking**: Got approval from Design to collapse some very similar pairs of colors that seem to have diverged in implementations over time. Some of the colors might be a little different, but we can tweak them later. Still have quite a few places from which to remove `dark-theme`, but this at least gets the theming much closer. Need to decide if I want to keep going in here or cut this and do the rest in a subsequent PR. <!-- Add screenshots or video recording to help explain your changes --> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5908-WIP-Make-components-themeable-2816d73d365081ffbc05d189fe71084b) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace color/dark-color pairs in components with design tokens to allow for easy overriding.
Changes
Review Focus
Still have quite a few places from which to remove
dark-theme, but this at least gets the theming much closer.Need to decide if I want to keep going in here or cut this and do the rest in a subsequent PR.
Screenshots (if applicable)
┆Issue is synchronized with this Notion page by Unito